Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support easy option setting of fill function arguments on function insertion #418

Closed
ghentschke opened this issue Feb 15, 2025 · 7 comments · Fixed by #419
Closed

Support easy option setting of fill function arguments on function insertion #418

ghentschke opened this issue Feb 15, 2025 · 7 comments · Fixed by #419
Assignees

Comments

@ghentschke
Copy link
Contributor

if i do use auto complete for a function call, i still get the auto fill for parameters even though i tried to disable it in the content assist in c/c++

I am not sure if I understand you correctly. So you disabled the Enable auto activation on typing as shown in my screenshot above and you still get a completion proposal which you don't want or is the completion proposal content wrong?

the content is wrong, for example if i type pack.. and do content assist , when i choose packet_capture i expect to be complete packet_capture and not shoved with the entire method signature which just has me do a cleanup afterwords

this looks like the effects of this setting in play even though it's off.
Image

Originally posted by @emaayan in #392

@ghentschke
Copy link
Contributor Author

Could be fixed by setting the clangd command line argument --function-arg-placeholders=true.

@emaayan
Copy link

emaayan commented Feb 16, 2025

Could be fixed by setting the clangd command line argument --function-arg-placeholders=true.

yes i know, but it's just a stop gap solution, no one really knows about this hidden thing, it needs to be the same checkbox setting.
TBH, i'm trying to write a simple plugin for eclipse, and in it's java's contnet assist is a clunky compared to intellij's

@ruspl-afed
Copy link
Member

and in it's java's contnet assist is a clunky compared to intellij's

It would be more fair to compare investments as well .And you are welcome to contribute improvements to Eclipse JDT

@ghentschke
Copy link
Contributor Author

Image

ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Feb 16, 2025
with `Fill function arguments and show guessed arguments` option to
comply with old C/C++ editor Content Assist preference page.
The option is only available on workspace level (preference page only)
since we currently support only a single LS per workspace.

fixes eclipse-cdt#418
@ghentschke ghentschke self-assigned this Feb 16, 2025
@emaayan
Copy link

emaayan commented Feb 16, 2025

and in it's java's contnet assist is a clunky compared to intellij's

It would be more fair to compare investments as well .And you are welcome to contribute improvements to Eclipse JDT

meanwhile i can barely find out how to create a plugin that has a global field in a status bar, it started by me wanting to use a plugin that talks to a local chat LLM, but then i discovered the amount of tokens a file has is important, so i thought i ok, I'll make a plugin that just shows the amount of tokens in each file the same way eclipse shows amount of chars in a file, i already have a library for it, but wait, i can't use maven for this, i have to osgi package, . then it spiraled downwards because i discovered i can't use update site to download PDE but i actually get a whole new eclipse instead.

@ruspl-afed
Copy link
Member

but wait, i can't use maven for this, i have to osgi package

you can, but with tycho

this repository is also a set of eclipse plug-ins and you may have a look how we produce installable units from it starting from root pom.xml

@emaayan
Copy link

emaayan commented Feb 16, 2025

but wait, i can't use maven for this, i have to osgi package

you can, but with tycho

this repository is also a set of eclipse plug-ins and you may have a look how we produce installable units from it starting from root pom.xml

i know i looked at tycho in the beginning , but i wasn't sure how much of it is actually being used in the field, and how much of it is supported directly by eclipse , like if specify a dependency in maven would show up under the plugin.xml page? would i still be able to use the regular launch configuration for eclipse application, etc..

ghentschke added a commit that referenced this issue Feb 17, 2025
with `Fill function arguments and show guessed arguments` option to
comply with old C/C++ editor Content Assist preference page.
The option is only available on workspace level (preference page only)
since we currently support only a single LS per workspace.

fixes #418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants