Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanding the children of a translation unit in project explorer locks/freezes UI #305

Closed
ghentschke opened this issue Apr 22, 2024 · 0 comments · Fixed by #324
Closed

Expanding the children of a translation unit in project explorer locks/freezes UI #305

ghentschke opened this issue Apr 22, 2024 · 0 comments · Fixed by #324
Assignees
@ghentschke
Labels
bug Something isn't working
Milestone
2.0.0

Comments

@ghentschke
Copy link
Contributor

ghentschke commented Apr 22, 2024 •
edited
Loading

When the children of a large translation unit will be expanded in the Project Explorer view, the UI gets locked for minutes until the tree has been filled with child elements:
image
@ghentschke ghentschke self-assigned this Apr 30, 2024
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue May 25, 2024
@ghentschke
[eclipse-cdt#305] limit TU children/symbols to be added
ffc1b22 
...to prevent a longer UI freeze. More children can be shown in
navigator Treeview in Project Explorer via 'Show next x items from
remaining y'. The limit will be taken from the 'Initial maximum number
of elements shown in views' in the General preference page.

fixes eclipse-cdt#305
@ghentschke ghentschke mentioned this issue May 25, 2024
Merged
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue May 25, 2024
@ghentschke
[eclipse-cdt#305] use fixed limit for initial children of a TU
f954156 
Reasons:
- since more than 100 items cannot be displayed in an average monitor,
we'll limit it here. 100 symbols deliver an acceptable UI response.
- WorkbenchPlugin.getDefault() is not public API
ghentschke added a commit that referenced this issue May 25, 2024
@ghentschke
[#305] limit TU children/symbols to be added (#324)
2041bad 
[#305] limit TU children/symbols to be added

...to prevent a longer UI freeze. More children can be shown in
navigator Treeview in Project Explorer via 'Show next x items from
remaining y'. The limit will be taken from the 'Initial maximum number
of elements shown in views' in the General preference page.

should fix #305
@ghentschke ghentschke added this to the 2.0.0 milestone May 25, 2024
@ghentschke ghentschke added the bug Something isn't working label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghentschke ghentschke

Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

[#305] limit TU children/symbols to be added ghentschke/eclipse-cdt-lsp
1 participant
@ghentschke