Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EnableExpression and enabledWhen from serverProvider schema #115

Closed
ghentschke opened this issue Jun 10, 2023 · 0 comments · Fixed by #116
Closed

Remove EnableExpression and enabledWhen from serverProvider schema #115

ghentschke opened this issue Jun 10, 2023 · 0 comments · Fixed by #116
Milestone
1.0.0

Comments

@ghentschke
Copy link
Contributor

Since the org.eclipse.cdt.lsp.server.enable.HasLanguageServerPropertyTester (which is used to enable the LSP based C/C++ editor and language server) relies on the isEnabledFor(IProject) from the ICLanguageServerProvider the enable expression and the enabledWhen element in the serverProvider schema is obsolet.
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Jun 10, 2023
@ghentschke
[eclipse-cdt#115] Remove EnableExpression and enabledWhen from server…
8c7aa99 
…Provider

schema

Since the HasLanguageServerPropertyTester (which is used to enable the
LSP based C/C++ editor and language server) relies on the
isEnabledFor(IProject) from the ICLanguageServerProvider the enable
expression and the enabledWhen element in the serverProvider schema is
obsolet.
@ghentschke ghentschke mentioned this issue Jun 10, 2023
Merged
ruspl-afed pushed a commit that referenced this issue Jun 11, 2023
@ghentschke
[#115] Remove EnableExpression and enabledWhen from serverProvider (#116
4328fc7 
)

schema

Since the HasLanguageServerPropertyTester (which is used to enable the
LSP based C/C++ editor and language server) relies on the
isEnabledFor(IProject) from the ICLanguageServerProvider the enable
expression and the enabledWhen element in the serverProvider schema is
obsolet.
@jonahgraham jonahgraham added this to the 1.0.0 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

[#115] Remove EnableExpression and enabledWhen from serverProvider ghentschke/eclipse-cdt-lsp
2 participants
@jonahgraham @ghentschke