-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert autofit smoothing introduced in PR #82 and use debouncing resize events #99
Revert autofit smoothing introduced in PR #82 and use debouncing resize events #99
Conversation
@tortmayr Sorry for the headache I have caused for your PR! I reverted the commit that caused the issues for you. @jreineckearm, @colin-grant-work What do you think about the new solution? |
@haydar-metin So from my side both approaches work and we should probably go with the solution that offers the better look & feel. |
Will be addressed with eclipse-cdt-cloud#99
Will be addressed with eclipse-cdt-cloud#99
Thanks, @haydar-metin , I tested it and I see now the effect that you meant despite the debounce. |
@haydar-metin , I'd suggest to merge this change as it is after resolving merge conflicts. It fixes the copy functionality. Maybe reduce the debounce to 100ms which looks a little smoother already. We can look into further enhancing the rendering again at a later point. |
ed152d2
to
50dfbfc
Compare
@jreineckearm I reduced the delay - it feels smoother now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me! 👍
What it does
Reverts commit 30ab368 and introduces an alternative solution
How to test
Commit: 62354e3
Increasing the width of the webview: No issues - new groups will be appended
Decreasing the width of the webview: The content of the data-column will break until the autofit calculation runs.
Commit: ed152d2
Now, we wait until the user stops the movement (200ms) and trigger the change afterwards. The only disadvantage we have is, that we need to wait a little.
Source Problem
There is a time delay:
Consequently, there is flickering.
Alternative solution
Remove CSS solution which causes issues and execute the autofitting after the user stops with debounce.
Review checklist
Reminder for reviewers