Skip to content

Commit

Permalink
Introduce Auto-Append scrolling behavior and remove Infinite scroll b…
Browse files Browse the repository at this point in the history
…ehavior
  • Loading branch information
haydar-metin committed Feb 27, 2024
1 parent d1400a1 commit 2e681c2
Show file tree
Hide file tree
Showing 9 changed files with 323 additions and 98 deletions.
11 changes: 11 additions & 0 deletions media/options-widget.css
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@
row-gap: 12px;
}

.form-textfield {
position: relative;
padding-bottom: 16px;
}

.form-textfield > input {
width: 150px;
}
Expand All @@ -81,6 +86,12 @@
align-self: start;
}

.form-options-memory-read-argument-hint {
position: absolute;
bottom: 0;
color: var(--vscode-descriptionForeground);
}

.advanced-options-content h2 {
font-size: 120%;
margin: 0.5rem 0 0 0;
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -210,12 +210,12 @@
"type": "string",
"enum": [
"Paginate",
"Infinite"
"Auto-Append"
],
"default": "Paginate",
"enumDescriptions": [
"Maintains a consistent memory size, replacing the previous request.",
"Appends new memory to bounds of current request, resulting in a growing list."
"Appends new memory to the bounds of the current request on reaching the end of the list, resulting in a growing list."
],
"description": "Behavior when adding more memory beyond the current view."
},
Expand Down
23 changes: 23 additions & 0 deletions src/common/typescript.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/********************************************************************************
* Copyright (C) 2024 EclipseSource and others.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0 which is available at
* http://www.eclipse.org/legal/epl-2.0.
*
* This Source Code may also be made available under the following Secondary
* Licenses when the conditions for such availability set forth in the Eclipse
* Public License v. 2.0 are satisfied: GNU General Public License, version 2
* with the GNU Classpath Exception which is available at
* https://www.gnu.org/software/classpath/license.html.
*
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
********************************************************************************/

export type RequiredKey<T, K extends keyof T> = T & { [P in K]-?: T[P] };

export function isObject(arg: unknown): arg is object {
return typeof arg === 'object' &&
!Array.isArray(arg) &&
!!arg;
}
Loading

0 comments on commit 2e681c2

Please sign in to comment.