-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github actions for build and publish to Open-VSIX and Visual Studio Code Marketplace #130
Add Github actions for build and publish to Open-VSIX and Visual Studio Code Marketplace #130
Conversation
- build - publish (Open-VSIX and VS Code Marketplace) Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me.
@jreineckearm, as @thegecko has full rights on here and you are both in the same timezone, can @thegecko merge and work with him on coordinating the various updates? I don't want to be a blocker by being in the loop in unneeded ways. In other words I give my blanket approval for #119 related changes.
If there is concern that breaking changes are being made, bumping the major version to 2.0 would make sense to me so that consumers know to be aware of unexpected changes.
Does this resolve #40 as well? Can the automated publishing done by the |
@spoenemann , I think this would replace the automated publishing process. The idea is that the tag-push sets things off. |
Changes
This PR addresses #119 and adds Github Actions for
Github actions have been reused from https://github.com/eclipse-cdt-cloud/vscode-memory-inspector/blob/915701a0b5742e218e893cfa0869a48b21005c8a/.github/workflows/ci.yml
Node version has been changed to 14.x to reflect the currently included node types dev dependency. But this can be easily changed to a newer version.
Other changes in this PR
.vscodeignore
list. Might need another update to avoid shipping the full node_modules folder including dev dependencies. But should be done separately and with more understanding of production dependencies.Note: The actions have not been tested yet in this repo! The
.vscodeignore
updates have been tested locally.The build action should run on PR pushes unless I forgot something. So, hopefully gets tested after opening this PR.The build action requires updates to this repo's CI which I can't add myself. And presumably will break other PRs until this one here is merged. @thegecko, @jonahgraham I need help here as I don't have required rights to make the changes.How to publish releases
In order to make a release, you need to
package.json
as before.main
branch. This should start the release actions to both Open-VSIX and the VS Code Marketplace. Also, a release is created on this Github repo which should include the VSIX file as asset.Findings while working on this
node_modules
folder.