Disassembly address handling improvement #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgraham
approved these changes
Jan 22, 2025
jonahgraham
added a commit
to jonahgraham/cdt-gdb-vscode
that referenced
this pull request
Jan 23, 2025
Includes these changes from the adapter: - Add supportsEvaluateForHovers - eclipse-cdt-cloud/cdt-gdb-adapter#347 - Disassembly address handling improvement - eclipse-cdt-cloud/cdt-gdb-adapter#348
|
@asimgunes published to npm. Please let me know if anything looks amiss. |
jonahgraham
added a commit
to eclipse-cdt-cloud/cdt-gdb-vscode
that referenced
this pull request
Jan 23, 2025
Includes these changes from the adapter: - Add supportsEvaluateForHovers - eclipse-cdt-cloud/cdt-gdb-adapter#347 - Disassembly address handling improvement - eclipse-cdt-cloud/cdt-gdb-adapter#348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jonahgraham ,
We observe some issues in while using the disassembly in embedded devices due to sending disassemble request for negative memory regions. We implemented a code-update to limit the lower bound of the query to the address 0x0.
If we still need to fill more instructions depending on the DAP request, you may realise that we used relative addresses in the empty instructions (e.g. (0x00)-2, (0x00)-4 etc). This is arguable and I am happy to hear your thoughts. Simply the VSCode is ignoring these lines and not showing in the disassembly window (maybe because they are not convertable to number or bigint).
It was hard to check this behaviour in unit test, thus I implemented a test for the internal function and checked the behaviour over that internal function.
Could you please review the update when you are suitable? I am happy to hear your feedback.
Kind regards
Asim