Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added unit tests for lot to stderr and stderr-full #812

Merged
merged 1 commit into from
Mar 11, 2024
Merged

added unit tests for lot to stderr and stderr-full #812

merged 1 commit into from
Mar 11, 2024

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Mar 8, 2024

Fixes: #806

Added unit tests verifying that logs entries via bc_log_to_stderr and bc_log_to_stderr_full are written to stderr.

@engelmi engelmi requested a review from mwperina March 8, 2024 12:03
@coveralls
Copy link

coveralls commented Mar 8, 2024 •
edited
Loading

Coverage Status

coverage: 80.044% (+0.1%) from 79.934%
when pulling 1c37f5e on engelmi:add-bc-log-to-stderr-tests
into bcb71f5 on eclipse-bluechi:main.

mwperina
mwperina approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelmi engelmi force-pushed the add-bc-log-to-stderr-tests branch from 0f4082f to bb4f716 Compare March 8, 2024 16:37
@mwperina mwperina force-pushed the add-bc-log-to-stderr-tests branch from bb4f716 to a38c673 Compare March 8, 2024 17:37
@engelmi @mwperina
added unit tests for lot to stderr and stderr-full
1c37f5e 
Fixes: eclipse-bluechi#806

Added unit tests verifying that logs entries via
bc_log_to_stderr and bc_log_to_stderr_full are written
to stderr.

Signed-off-by: Michael Engel <mengel@redhat.com>
@mwperina mwperina force-pushed the add-bc-log-to-stderr-tests branch from a38c673 to 1c37f5e Compare March 8, 2024 20:36
@engelmi engelmi merged commit e1f81fd into eclipse-bluechi:main Mar 11, 2024
20 checks passed
@engelmi engelmi deleted the add-bc-log-to-stderr-tests branch June 17, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwperina mwperina mwperina approved these changes

@alexlarsson alexlarsson Awaiting requested review from alexlarsson alexlarsson is a code owner

@mkemel mkemel Awaiting requested review from mkemel mkemel is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cover function bc_log_to_stderr_full_with_location from libbluechi/log/log.c by tests
3 participants
@engelmi @coveralls @mwperina