Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for bluechi-is-online system --monitor #1029

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nsimsolo
Copy link
Contributor

Adding integration test for bluechi-is-online system --monitor

  1. Start node and two agents, keep it running and verify system --monitor does not return output.
  2. Stop agent-one, keep agent-two running and verify system --monitor returns 1.
  3. Stop agent-two, keep agent-one running and verify system --monitor returns 1.
  4. Stop both agents and verify system --monitor returns 1.
  5. Stop Controller, keep agents running, verify system --monitor returns 1.

Fixes: #1022
Signed-off-by: Nisim simsolo nsimsolo@redhat.com

@nsimsolo nsimsolo force-pushed the bluechi-is-online-system-monitor branch from eda7124 to bb5b437 Compare January 20, 2025 10:48
@coveralls
Copy link

coveralls commented Jan 20, 2025

Coverage Status

coverage: 82.236%. remained the same
when pulling eca0807 on nsimsolo:bluechi-is-online-system-monitor
into 4decef2 on eclipse-bluechi:main.

@engelmi
Copy link
Member

engelmi commented Jan 20, 2025

Failing builds on rawhide should be fixed as soon as #1030 is merged.

Edit: #1030 has been merged. Please rebase.

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add link to the top/bottom of the commit message:
Fixes: https://github.com/eclipse-bluechi/bluechi/issues/1022
I only see it in the PR description, but not in the commit message.

LGTM, only a small NIT.

@nsimsolo nsimsolo force-pushed the bluechi-is-online-system-monitor branch from bb5b437 to eca0807 Compare January 21, 2025 11:19
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. Start node and two agents, keep it running and verify system --monitor does not return output.
2. Stop agent-one, keep agent-two running and verify system --monitor returns 1.
3. Stop agent-two, keep agent-one running and verify system --monitor returns 1.
4. Stop both agents and verify system --monitor returns 1.
5. Stop Controller, keep agents running, verify system --monitor returns 1.

Fixes: eclipse-bluechi#1022
Signed-off-by: nsimsolo <nsimsolo@redhat.com>
@nsimsolo nsimsolo force-pushed the bluechi-is-online-system-monitor branch from eca0807 to ec68994 Compare January 26, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests for bluechi-is-online system with --monitor parameter
4 participants