-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for bluechi-is-online node with --wait parameter #1028
Add integration test for bluechi-is-online node with --wait parameter #1028
Conversation
edb0ae8
to
8c48eff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add link to the top/bottom of the commit message:
Fixes: https://github.com/eclipse-bluechi/bluechi/issues/1019
I only see it in the PR description, but not in the commit message.
LGTM, only a small NIT.
tests/tests/tier0/bluechi-is-online-node-wait/test_bluechi_is_online_node_wait.py
Outdated
Show resolved
Hide resolved
8a373c5
to
bbc6c06
Compare
/packit retest-failed |
70f4dcd
to
d30fdde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just small nit
1. Start agent and verify --wait option returns 0 immediately. 2. Stop agent and verify --wait returns 1 after wait time is expired. 3. Stop agent, run 'bluechi-is-online node --wait' start agent and verify --wait returns 0 before the wait time expires. Fixes: eclipse-bluechi#1019 Signed-off-by: Dana Orr <dorr@redhat.com>
d30fdde
to
4a0df07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding integration test for bluechi-is-online node --wait with three tests:
Start agent and verify --wait option returns 0 immediately.
Stop agent and verify --wait returns 1 after wait time is expired.
Stop agent, run 'bluechi-is-online node --wait' start agent and verify --wait returns 0 before the wait time expires.
Fixes: #1019
Signed-off-by: Dana Orr dorr@redhat.com