Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for bluechi-is-online node with --wait parameter #1028

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

DanaOrr
Copy link
Contributor

@DanaOrr DanaOrr commented Jan 20, 2025

Adding integration test for bluechi-is-online node --wait with three tests:
Start agent and verify --wait option returns 0 immediately.
Stop agent and verify --wait returns 1 after wait time is expired.
Stop agent, run 'bluechi-is-online node --wait' start agent and verify --wait returns 0 before the wait time expires.

Fixes: #1019
Signed-off-by: Dana Orr dorr@redhat.com

@DanaOrr DanaOrr force-pushed the bluechi-is-online-node-wait branch from edb0ae8 to 8c48eff Compare January 20, 2025 09:31
@coveralls
Copy link

coveralls commented Jan 20, 2025

Coverage Status

coverage: 82.251% (+0.02%) from 82.236%
when pulling 4a0df07 on DanaOrr:bluechi-is-online-node-wait
into 4decef2 on eclipse-bluechi:main.

@engelmi
Copy link
Member

engelmi commented Jan 20, 2025

Failing builds on rawhide should be fixed as soon as #1030 is merged.

Edit: #1030 has been merged. Please rebase.

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add link to the top/bottom of the commit message:
Fixes: https://github.com/eclipse-bluechi/bluechi/issues/1019
I only see it in the PR description, but not in the commit message.

LGTM, only a small NIT.

@DanaOrr DanaOrr force-pushed the bluechi-is-online-node-wait branch 4 times, most recently from 8a373c5 to bbc6c06 Compare January 21, 2025 08:39
@mkemel
Copy link
Member

mkemel commented Jan 21, 2025

/packit retest-failed

@DanaOrr DanaOrr force-pushed the bluechi-is-online-node-wait branch 2 times, most recently from 70f4dcd to d30fdde Compare January 21, 2025 09:54
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just small nit

tests/bluechi_test/bluechi_is_online.py Outdated Show resolved Hide resolved
1. Start agent and verify --wait option returns 0 immediately.
2. Stop agent and verify --wait returns 1 after wait time is expired.
3. Stop agent, run 'bluechi-is-online node --wait' start agent and verify --wait returns 0 before the wait time expires.

Fixes: eclipse-bluechi#1019
Signed-off-by: Dana Orr <dorr@redhat.com>
@DanaOrr DanaOrr force-pushed the bluechi-is-online-node-wait branch from d30fdde to 4a0df07 Compare January 21, 2025 12:40
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mkemel mkemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkemel mkemel merged commit 4deaab9 into eclipse-bluechi:main Jan 21, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests for bluechi-is-online node with --wait parameter
5 participants