Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test for bluechi-is-online node <name> --monitor #1017

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Integration test for bluechi-is-online node <name> --monitor #1017

merged 1 commit into from
Jan 9, 2025

Conversation

nsimsolo
Copy link
Contributor

@nsimsolo nsimsolo commented Jan 2, 2025

Adding integration test for bluechi-is-online node --monitor

  1. Start node and agent, keep it running and verify --monitor does not return output.
  2. Stop node and verify --monitor returns 1.

Fixes: #1010
Signed-off-by: Nisim simsolo nsimsolo@redhat.com

@nsimsolo nsimsolo force-pushed the bluechi-is-online-node-monitor branch 2 times, most recently from 17ff95a to 3519c49 Compare January 2, 2025 10:56
@coveralls
Copy link

coveralls commented Jan 2, 2025 •
edited
Loading

Coverage Status

coverage: 82.341% (-0.02%) from 82.356%
when pulling 937d569 on nsimsolo:bluechi-is-online-node-monitor
into 7f73321 on eclipse-bluechi:main.

@nsimsolo nsimsolo force-pushed the bluechi-is-online-node-monitor branch from 3519c49 to 18b4c81 Compare January 2, 2025 11:08
@nsimsolo nsimsolo force-pushed the bluechi-is-online-node-monitor branch from 18b4c81 to a4511ad Compare January 7, 2025 11:10
@nsimsolo nsimsolo force-pushed the bluechi-is-online-node-monitor branch 2 times, most recently from 4cc672c to 2f0e91d Compare January 8, 2025 11:44
mwperina
mwperina reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just a few small comments

tests/tests/tier0/bluechi-is-online-node-monitor/test_bluechi_is_online_node_monitor.py Show resolved Hide resolved
tests/bluechi_test/bluechi_is_online.py Outdated Show resolved Hide resolved
tests/tests/tier0/bluechi-is-online-node-monitor/test_bluechi_is_online_node_monitor.py Show resolved Hide resolved
tests/tests/tier0/bluechi-is-online-node-monitor/test_bluechi_is_online_node_monitor.py Outdated Show resolved Hide resolved
tests/tests/tier0/bluechi-is-online-node-monitor/test_bluechi_is_online_node_monitor.py Show resolved Hide resolved
tests/tests/tier0/bluechi-is-online-node-monitor/test_bluechi_is_online_node_monitor.py Outdated Show resolved Hide resolved
@nsimsolo
Integration test for bluechi-is-online node <name> --monitor
937d569 
1. Start node and agent, keep it running and verify --monitor does not return output.
2. Stop node and verify --monitor returns 1.

Signed-off-by: nsimsolo <nsimsolo@redhat.com>
@nsimsolo nsimsolo force-pushed the bluechi-is-online-node-monitor branch from 2f0e91d to 937d569 Compare January 9, 2025 10:10
mwperina
mwperina approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

engelmi
engelmi approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina merged commit 7c24ce4 into eclipse-bluechi:main Jan 9, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelmi engelmi engelmi approved these changes

@mwperina mwperina mwperina approved these changes

@alexlarsson alexlarsson Awaiting requested review from alexlarsson alexlarsson is a code owner

@mkemel mkemel Awaiting requested review from mkemel mkemel is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration tests for bluechi-is-online node with --monitor parameter
5 participants
@nsimsolo @coveralls @mwperina @engelmi @mkemel