-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix selinux policy for uds #1015
Merged
engelmi
merged 2 commits into
eclipse-bluechi:main
from
engelmi:fix-selinux-policy-for-uds
Dec 19, 2024
Merged
Fix selinux policy for uds #1015
engelmi
merged 2 commits into
eclipse-bluechi:main
from
engelmi:fix-selinux-policy-for-uds
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
requested review from
alexlarsson,
mkemel and
rhatdan
as code owners
December 18, 2024 08:17
engelmi
force-pushed
the
fix-selinux-policy-for-uds
branch
from
December 18, 2024 08:18
737f445
to
59c7bb3
Compare
mwperina
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alexlarsson
reviewed
Dec 18, 2024
alexlarsson
reviewed
Dec 18, 2024
alexlarsson
reviewed
Dec 18, 2024
👍 |
Relates to: eclipse-bluechi#997 The /run directory is being cleaned up on every system boot. If the /run/bluechi directory is only created during RPM install, it is removed on the next system shutdown. Therefore, the tmpfiles.d is being used to ensure that the /run/bluechi directory will be recreated on each boot - similar to /run/podman. Signed-off-by: Michael Engel <mengel@redhat.com>
Relates to: eclipse-bluechi#997 The SELinux policy for BlueChi did not allow using UDS. Since these where introduces in eclipse-bluechi#997 the policy has been updated to allow the bluechi-controller to create and manage the UDS in /run (or /var/run) and the bluechi-agent to connect to it. Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
force-pushed
the
fix-selinux-policy-for-uds
branch
from
December 18, 2024 13:24
59c7bb3
to
7a2c989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated SELinux policy
Relates to: #997
The SELinux policy for BlueChi did not allow using UDS. Since these where introduces in #997 the policy has been updated to allow the bluechi-controller to create and manage the UDS in /run (or /var/run) and the bluechi-agent to
connect to it.
Fixed creating /run directory
Relates to: #997
The /run directory is being cleaned up on every system boot. If the /run/bluechi directory is only created during RPM install, it is removed on the next system shutdown. Therefore, the tmpfiles.d is being used to ensure that the /run/bluechi directory will be recreated on each boot - similar to /run/podman.
Signed-off-by: Michael Engel mengel@redhat.com