Fixed overrunning log_level_to_string for invalid loglevel #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Engel <mengel@redhat.com>
|
/packit build |
|
/packit build |
|
/packit retest-failed |
1 similar comment
|
/packit retest-failed |
|
Testing Farm currently fails to provision the environment. Since the all tests passed in GH CI and on one run in TF, lets merge. (In a previous run TF with valgrind succeeded as well). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a Buffer Overflow in the
log_level_to_stringwhen passing in aLogLevel(i.e. an index) out of range of thelog_level_stringsarray. This PR fixes thelog_level_to_stringfunction and adds an unit test incl. these test cases to verify it.