Fix documentation workflow #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the current documentation workflow:
It does not make sense to add a pull_request_trigger for building the GH Pages website as an PR will overwrite the currently deployed page.
If you want a preview feature, take a look at the https://github.com/eclipse-langium/langium-website/blob/main/.github/workflows/preview.yml workflow that publishes the site from PRs to a separate repo for inspection and adds a link to the PR itself. If you like this approach we can help you set this up, open a ticket in the HelpDesk about it.
cc @wimjongman