Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

[i18n] Added translation for author of binding #5176

Closed
wants to merge 1 commit into from
Closed

[i18n] Added translation for author of binding #5176

wants to merge 1 commit into from

Conversation

cweitkamp
Copy link
Contributor

@cweitkamp cweitkamp commented Mar 3, 2018

  • Added translation for author of binding
  • Corrected linters in documentation

In OH2 we already have some bindings which are written / maintained by more than one author (e.g. Netatmo). To provide fully internationalization we should translate the author tag as well.

https://github.com/openhab/openhab2-addons/blob/14dacc3104dc8076310433e635f9f0a1d591b9a9/addons/binding/org.openhab.binding.netatmo/ESH-INF/binding/binding.xml#L9

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@lolodomo
Copy link
Contributor

lolodomo commented Mar 4, 2018

And I can probably be added for the netatmo binding ;)

@maggu2810
Copy link
Contributor

👍 for the translation support.

But to be honest, I don't like the author for bindings in the official ESH repo.
That is a meta information for the binding but what is the intention?
I assume the author don't like to be contacted personally but prefer bug reports to the ESH repo.
And is the one that started the word (initial contribution) really the author of the whole binding?
Why not using "Eclipse SmartHome project" for bindings that are maintained by the Eclipse SmartHome community?

@kaikreuzer
Copy link
Contributor

Sorry, this PR does not make any sense to me.
First of all, names of people are usually not translated into other languages. Their name is their name.
Second, it is "author" and not "authors", hence for bindings where there are more than a single author, we already usually simply removed that information.
Third, I agree with @maggu2810, it was rather a bad idea of including it in the first place - it does not really have any value here. I'd therefore also rather suggest to phase its use out and move this information to the "technical meta-data" as discussed in #4503.

@cweitkamp
Copy link
Contributor Author

Alright, I didn't see that one coming. If we don't want to have the "author", we don't need a translation for it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants