Configurable ItemChannelLinks

[sjsf]

This allows adding some configuration properties onto links, e.g. though

  Switch someItem {
      channel="a:b:c:channel" [
          foo="bar",
          answer=42,
          always=true
      ]
  }

or the REST API.

As a consequence, ItemChannelLinks now also can be updated through the REST API.

❗️ This is API breaking, it adds a Configuration argument to BindingConfigReader.processBindingConfiguration(...). I wouldn't expect many implementations out there - apart from the OH1 compatibility layer. Let me know any concerns, than I will think of something different - but I didn't want to clutter the API without a need.

fixes #583
Signed-off-by: Simon Kaufmann simon.kfm@googlemail.com

[triller-telekom]

Two small comments from my side, please see them inline in the code.

[triller-telekom]

Unnecessary newline

[triller-telekom]

A number can contain any char from ID, so also a-z, A-Z, _?

[sjsf]

Stolen from Thing.xtext. Why should it be different?

[kaikreuzer]

@triller-telekom Think about numbers like -4.52E+6 and you will understand why it is that way :-)

[triller-telekom]

@kaikreuzer Thank you for this explanation, but I still don't understand why you allow different characters than e or E and _ for a number. Or is it just out of convenience reasons that you do not want to define a slightly different ID terminal? :)

[maggu2810]

I didn't have a look at the DSL items grammar, but the remaining part looks good to me.

[kaikreuzer]

@SJKA A question that I just stumbled over:

As you know, the channel property accepts a list of channels e.g.

channel="a:b:c:channel, d:e.f:channel, g:h:i:channel"

How does your chosen syntax for the configurations fit to this?

[sjsf]

The same configuration obviously gets applied to all the links, i.e.

      channel="a:b:c:channel, d:e:f:channel, g:h:i:channel" [
          foo="bar",
          answer=42,
          always=true
      ]

However, as far as I can see it is allowed to use the same binding configuration multiple times, i.e. if there should be different link configurations, then you'd simply split the one string up and make it three different ones like this:

      channel="a:b:c:channel" [
          foo="bar",
          answer=42,
          always=true
      ],
      channel="d:e:f:channel" [
          foo="bar",
          answer=43,
          always=true
      ],
      channel="g:h:i:channel" [
          foo="bar",
          answer=44,
          always=true
      ]

[kaikreuzer]

as far as I can see it is allowed to use the same binding configuration multiple times

Ok, thanks, that would be a solution. Do you just "believe" that it should work or did you check it?

[sjsf]

I'm a strong believer in things I have tried out!
I created #4378 in order to make you become a believer too 😉

[kaikreuzer]

Thanks :-)