This repository has been archived by the owner on May 7, 2020. It is now read-only.
AutomationWatchService uses relative path. #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikreuzer
reviewed
Nov 29, 2016
| protected AbstractWatchQueueReader buildWatchQueueReader(WatchService watchService, Path toWatch) { | ||
| return new WatchQueueReader(watchService, toWatch, provider); | ||
| protected AbstractWatchQueueReader buildWatchQueueReader(WatchService watchService, Path toWatch, | ||
| Map<WatchKey, Path> registredWatchKeys) { |
There was a problem hiding this comment.
typo: registeredWatchKeys
kaikreuzer
reviewed
Nov 29, 2016
| WatchQueueReader(WatchService watchService, Path dirToWatch, AbstractFileProvider provider) { | ||
| super(watchService, dirToWatch); | ||
| WatchQueueReader(WatchService watchService, Path dirToWatch, AbstractFileProvider provider, | ||
| Map<WatchKey, Path> registredWatchKeys) { |
There was a problem hiding this comment.
typo: registeredWatchKeys
maggu2810
approved these changes
Nov 29, 2016
Is this the correct issue reference...? |
Adapting the code of AutomationWatchService to use relative path. This change was necessary after eclipse-archived#2432 was merged. Signed-off-by: Svilen Valkanov <svilen.valkanov@musala.com>
55c5606 to
6876995
Compare
Thanks, I've corrected it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2557 (comment)
Adapting the code of AutomationWatchService to use relative path.
This change was necessary after #2432 was merged.
Signed-off-by: Svilen Valkanov svilen.valkanov@musala.com