This repository has been archived by the owner on May 7, 2020. It is now read-only.
added default constructors #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private final String value; | ||
|
|
||
| public StringType() { | ||
| this.value = ""; |
There was a problem hiding this comment.
For HSB and Percent type you already call the other constructor.
Perhaps we could use this(""); here
|
One minor comment on StringType. But at all, LGTM |
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
Ok, updated the StringType constructor accordingly. |
cdjackson
added a commit
to cdjackson/smarthome
that referenced
this pull request
Aug 1, 2016
* master: (29 commits) Fix mDNS discovery (bug eclipse-archived#577 eclipse-archived#1745) (eclipse-archived#1742) create thread pool for firmware update job on demand (eclipse-archived#1906) fixes yahoo weather config status provider (eclipse-archived#1937) minor changes for the config status message key handling as discussed in eclipse-archived#1819 (eclipse-archived#1933) added default constructors (eclipse-archived#1931) added gulp-util, which has been missing (eclipse-archived#1929) Bug fix: Input type text (eclipse-archived#1930) moved to its own repo at https://github.com/eclipse/smarthome.osgi-ri.enocean (eclipse-archived#1923) Support state options in control UI (eclipse-archived#1888) LIFX binding: Fix eclipse-archived#1915 IllegalMonitorStateException may occur when unlocking after sending broadcast packet (eclipse-archived#1919) re-added support for dimmable plug-in units (eclipse-archived#1913) use context equals case insensitive for password (eclipse-archived#1910) added ConfigStatusBridgeHandler (eclipse-archived#1898) Add title tooltip to icons (eclipse-archived#1892) added a hint about periodically executed jobs (eclipse-archived#1909) override methods to keep type information (eclipse-archived#1911) Hue binding: fix 1880 (eclipse-archived#1899) mark API dependencies as provided (eclipse-archived#1904) password context based input (eclipse-archived#1897) make BridgeBuilder a subclass of ThingBuilder and adapt BaseBridgeHandler.editThing() (eclipse-archived#1894) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1924
Signed-off-by: Kai Kreuzer kai@openhab.org