This repository has been archived by the owner on May 7, 2020. It is now read-only.
Revert "WatchService Provides File Name Instead of Relative Path" #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petarnv
pushed a commit
to petarnv/smarthome
that referenced
this pull request
Nov 1, 2016
* Fixes bug introduced by eclipse-archived#1597 reverted with eclipse-archived#1754, that led to duplicated directory names in FolderObserver * Added directory registration after initialization.This change allows all classes that extend AbstractWatchService to register directories to be watched, after the WatchService is initialized. This will be possible with the registerAllDirectoriesInternal() method.The implementaions can handle the DIRECTORY_CREATED event, in order to do that. * Added test cases for the registration of directories after service initialization * Test class is refactored * Improved javadoc of AbstractWatchService and AbstractQueueReader Signed-off-by: Svilen Valkanov <svilen.valkanov@musala.com>
svilenvul
added a commit
to MusalaSoft/smarthome
that referenced
this pull request
Nov 10, 2016
…rchived#1754. The implementation of FolderObserver#processWatchEvent() does not get the file name correctly. This led to duplicated directory names (see the logs in eclipse-archived#1597). AbstractWatchServiceTest is modified to run on different OS.: Signed-off-by: Svilen Valkanov, svilen.valkanov@musala.com (github: svilenvul )
svilenvul
pushed a commit
to MusalaSoft/smarthome
that referenced
this pull request
Nov 10, 2016
…rchived#1754. The implementation of FolderObserver#processWatchEvent() does not get the file name correctly. This led to duplicated directory names (see the logs in eclipse-archived#1597). AbstractWatchServiceTest is modified to run on different OS.: Signed-off-by: Svilen Valkanov <svilen.valkanov@musala.com>
svilenvul
pushed a commit
to MusalaSoft/smarthome
that referenced
this pull request
Nov 10, 2016
…rchived#1754. The implementation of FolderObserver#processWatchEvent() does not get the file name correctly. This led to duplicated directory names (see the logs in eclipse-archived#1597). AbstractWatchServiceTest is modified to run on different OS. Signed-off-by: Svilen Valkanov <svilen.valkanov@musala.com>
svilenvul
pushed a commit
to MusalaSoft/smarthome
that referenced
this pull request
Nov 10, 2016
…rchived#1754. The implementation of FolderObserver#processWatchEvent() does not get the file name correctly. This led to duplicated directory names (see the logs in eclipse-archived#1597). AbstractWatchServiceTest is modified to run on different OS. Signed-off-by: Svilen Valkanov <svilen.valkanov@musala.com>
svilenvul
pushed a commit
to MusalaSoft/smarthome
that referenced
this pull request
Nov 10, 2016
…rchived#1754. The implementation of FolderObserver#processWatchEvent() does not get the file name correctly. This led to duplicated directory names (see the logs in eclipse-archived#1597). AbstractWatchServiceTest is modified to run on different OS. Signed-off-by: Svilen Valkanov <svilen.valkanov@musala.com>
svilenvul
pushed a commit
to MusalaSoft/smarthome
that referenced
this pull request
Nov 11, 2016
…rchived#1754. The implementation of FolderObserver#processWatchEvent() does not get the file name correctly. This led to duplicated directory names (see the logs in eclipse-archived#1597). AbstractWatchServiceTest is modified to run on different OS. Signed-off-by: Svilen Valkanov <svilen.valkanov@musala.com>
kaikreuzer
pushed a commit
that referenced
this pull request
Nov 29, 2016
The implementation of FolderObserver#processWatchEvent() does not get the file name correctly. This led to duplicated directory names (see the logs in #1597). AbstractWatchServiceTest is modified to run on different OS. Signed-off-by: Svilen Valkanov <svilen.valkanov@musala.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1597