BasicUI: Treat Switch on NumberItem not as ON/OFF Switch (#3493)

* BasicUI: Treat Switch on NumberItem not as ON/OFF Switch * Only convert state of plain switches without mappings * Fix exception in test due to new check in implementation * Test for state conversion on switch with mapping Fixes #3472 Signed-off-by: Stefan Triller <stefan.triller@telekom.de>
eclipse-archived · May 22, 2017 · 1b2ab9f · 1b2ab9f
1 parent 38b3e20
commit 1b2ab9f
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/...ui.test/src/test/java/org/eclipse/smarthome/ui/internal/items/ItemUIRegistryImplTest.java b/...ui.test/src/test/java/org/eclipse/smarthome/ui/internal/items/ItemUIRegistryImplTest.java
@@ -13,6 +13,7 @@
 
 import java.text.DecimalFormatSymbols;
 
+import org.eclipse.emf.common.util.BasicEList;
 import org.eclipse.smarthome.core.items.Item;
 import org.eclipse.smarthome.core.items.ItemNotFoundException;
 import org.eclipse.smarthome.core.items.ItemRegistry;
@@ -26,6 +27,7 @@
 import org.eclipse.smarthome.core.types.State;
 import org.eclipse.smarthome.core.types.StateDescription;
 import org.eclipse.smarthome.core.types.UnDefType;
+import org.eclipse.smarthome.model.sitemap.Mapping;
 import org.eclipse.smarthome.model.sitemap.Sitemap;
 import org.eclipse.smarthome.model.sitemap.SitemapFactory;
 import org.eclipse.smarthome.model.sitemap.Slider;
@@ -328,12 +330,36 @@ public void testStateConversionForSwitchWidgetThroughGetState() throws ItemNotFo
 
         Switch switchWidget = mock(Switch.class);
         when(switchWidget.getItem()).thenReturn("myItem");
+        when(switchWidget.getMappings()).thenReturn(new BasicEList<Mapping>());
 
         State stateForSwitch = uiRegistry.getState(switchWidget);
 
         assertEquals(OnOffType.ON, stateForSwitch);
     }
 
+    @Test
+    public void testStateConversionForSwitchWidgetWithMappingThroughGetState() throws ItemNotFoundException {
+        State colorState = new HSBType("23,42,50");
+
+        ColorItem colorItem = new ColorItem("myItem");
+        colorItem.setLabel("myItem");
+        colorItem.setState(colorState);
+
+        when(registry.getItem("myItem")).thenReturn(colorItem);
+
+        Switch switchWidget = mock(Switch.class);
+        when(switchWidget.getItem()).thenReturn("myItem");
+
+        Mapping mapping = mock(Mapping.class);
+        BasicEList<Mapping> mappings = new BasicEList<Mapping>();
+        mappings.add(mapping);
+        when(switchWidget.getMappings()).thenReturn(mappings);
+
+        State stateForSwitch = uiRegistry.getState(switchWidget);
+
+        assertEquals(colorState, stateForSwitch);
+    }
+
     @Test
     public void testStateConversionForSliderWidgetThroughGetState() throws ItemNotFoundException {
         State colorState = new HSBType("23,42,75");

diff --git a/...marthome.ui/src/main/java/org/eclipse/smarthome/ui/internal/items/ItemUIRegistryImpl.java b/...marthome.ui/src/main/java/org/eclipse/smarthome/ui/internal/items/ItemUIRegistryImpl.java
@@ -505,7 +505,10 @@ private State convertState(Widget w, Item i) {
         if (w instanceof Slider || (w instanceof Switch && i instanceof RollershutterItem)) {
             returnState = i.getStateAs(PercentType.class);
         } else if (w instanceof Switch) {
-            returnState = i.getStateAs(OnOffType.class);
+            Switch sw = (Switch) w;
+            if (sw.getMappings().size() == 0) {
+                returnState = i.getStateAs(OnOffType.class);
+            }
         }
 
         // if returnState is null, a conversion was not possible