This repository has been archived by the owner on Mar 5, 2021. It is now read-only.
Fix bundles with dir-shape have needed instruction in content.xml (#128) #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. This looks good to me. All that is requires is that you sign the Eclipse Contributor Agreement (ECA) and add the Let me know if you need any help with that. |
1b02bbf to
ad98ea9
Compare
ctron
suggested changes
Aug 13, 2018
| final FeatureInformation fi = new FeatureInformation (); | ||
|
|
||
| fi.setId ( "f1" ); | ||
| fi.setId ( feature_id ); |
There was a problem hiding this comment.
Please don't use underscores. -> featureId.
There was a problem hiding this comment.
Same for the other locations.
|
|
||
| final List<InstallableUnit> ius = InstallableUnit.fromFeature ( fi ); | ||
| @Test | ||
| public void fragmentSecificPropertiesAddedToIU () throws Exception |
5e03c10 to
76217a3
Compare
|
I think I'm done. I also rebased the the commits on master. |
ctron
approved these changes
Aug 14, 2018
|
Could you please rebase the branch. This should fix the issues with travis. |
76217a3 to
536a2cc
Compare
|
Please don't merge yet. I think there is a bug in my code. |
536a2cc to
e235dfb
Compare
added 5 commits
August 18, 2018 12:06
…lipse-archived#128) When a bundles has the Eclipse-BundleShape: dir manifest entry the installable unit in content.xml the touchpointData must have <instruction key='zipped'>true</instruction> Otherwise when tycho builds a product the bundle is not beeing extracted. Signed-off-by: Veselin Markov <veselin_m84@yahoo.com>
Signed-off-by: Veselin Markov <veselin_m84@yahoo.com>
Signed-off-by: Veselin Markov <veselin_m84@yahoo.com>
the genereted provides-element now has the same type as repositores built by p2. See org.eclipse.equinox.p2.publisher.eclipse.BundlesAction vor details. Signed-off-by: Veselin Markov <veselin_m84@yahoo.com>
Signed-off-by: Veselin Markov <veselin_m84@yahoo.com>
e235dfb to
030b755
Compare
|
Should be fixed now. Sorry about that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a bundles has the Eclipse-BundleShape: dir manifest entry the
installable unit in content.xml the touchpointData must have
true
Otherwise when tycho builds a product the bundle is not beeing
extracted.