This repository has been archived by the owner on Mar 5, 2021. It is now read-only.
Add support for %config(missingok) and %config(noreplace) #113
Comments
|
Looking at https://github.com/rpm-software-management/rpm/blob/79ca74e15e15c1d91a9a31a9ee90abc91736f390/lib/rpmfiles.h#L50 - adding support for all the file attributes might be useful. |
|
I completely agree. Could you make a PR for that? |
|
I can look at that - will need to setup an account and sign the CLA first. The changes would also be updating more than just the flags tho ( since access to FileFlags is encapsulated ). Currently however - how does one simply build the project? Running |
|
That would be awesome! I will amend the |
ctron
added a commit
that referenced
this issue
Sep 28, 2017
|
Ok, I did add a bit of information. Let me know if I can help you. |
talios
added a commit
to SMX-LTD/packagedrone
that referenced
this issue
Nov 14, 2017
This change replaces the existing means of setting a file as being a configuration file, by exposing FileFlags modification to SimpleFileInformationCustomizer. As part of this we also define the full set of RPM file flags, using the naming from the upstream RPM sources at https://github.com/rpm-software-management/rpm/blob/master/lib/rpmfiles.h Existing behaviour is (currently) deprecated and adapted to use the newer code. Fixes eclipse-archived#113
talios
added a commit
to SMX-LTD/packagedrone
that referenced
this issue
Nov 14, 2017
This change replaces the existing means of setting a file as being a configuration file, by exposing FileFlags modification to SimpleFileInformationCustomizer. As part of this we also define the full set of RPM file flags, using the naming from the upstream RPM sources at https://github.com/rpm-software-management/rpm/blob/master/lib/rpmfiles.h Existing behaviour is (currently) deprecated and adapted to use the newer code. Fixes eclipse-archived#113 Signed-off-by: Mark Derricutt <mark.derricutt@smxemail.com>
talios
added a commit
to SMX-LTD/packagedrone
that referenced
this issue
Nov 14, 2017
This change replaces the existing means of setting a file as being a configuration file, by exposing FileFlags modification to SimpleFileInformationCustomizer. As part of this we also define the full set of RPM file flags, using the naming from the upstream RPM sources at https://github.com/rpm-software-management/rpm/blob/master/lib/rpmfiles.h Existing behaviour is (currently) deprecated and adapted to use the newer code. Fixes eclipse-archived#113 Signed-off-by: Mark Derricutt <mark.derricutt@smxemail.com>
talios
added a commit
to SMX-LTD/packagedrone
that referenced
this issue
Nov 14, 2017
This change replaces the existing means of setting a file as being a configuration file, by exposing FileFlags modification to SimpleFileInformationCustomizer. As part of this we also define the full set of RPM file flags, using the naming from the upstream RPM sources at https://github.com/rpm-software-management/rpm/blob/master/lib/rpmfiles.h Existing behaviour is (currently) deprecated and adapted to use the newer code. Fixes eclipse-archived#113 Signed-off-by: Mark Derricutt <mark.derricutt@smxemail.com>
ctron
pushed a commit
that referenced
this issue
Nov 15, 2017
This change replaces the existing means of setting a file as being a configuration file, by exposing FileFlags modification to SimpleFileInformationCustomizer. As part of this we also define the full set of RPM file flags, using the naming from the upstream RPM sources at https://github.com/rpm-software-management/rpm/blob/master/lib/rpmfiles.h Existing behaviour is (currently) deprecated and adapted to use the newer code. Fixes #113 Signed-off-by: Mark Derricutt <mark.derricutt@smxemail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently
org.eclipse.packagedrone.utils.rpm.FileFlagsonly includes a setting forCONFIGURATION.It would good to include
CONFIGURATION_MISSING_OKandCONFIGURATION_NO_REPLACEsupport as well.I believe I can get around this currently by calling
addFile(String targetName, Path sourcePath, int mode, Instant mtime, Consumer<RpmBuilder.FileEntry> customizer)via reflection, since the customizer can callsetFlagsdirectly on theFileEntry( using 0.14.1 ).The text was updated successfully, but these errors were encountered: