Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure jwt_token is used if present #77

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Ensure jwt_token is used if present #77

merged 1 commit into from
Nov 11, 2020

Conversation

rjprins
Copy link
Contributor

@rjprins rjprins commented Nov 11, 2020

In some use cases the Client.jwt_token is set directly. A bug was introduced in #76 that would cause the JWT not to be included in the request in this case.
This change fixes that and adds a test.

@rjprins rjprins merged commit d8a2b02 into master Nov 11, 2020
@rjprins rjprins deleted the ensure-jwt-use branch November 11, 2020 10:17
wbolster-eiq added a commit that referenced this pull request Nov 16, 2020
As a follow-up to #76 and #77, only try to refresh a JWT token if using
JWT authentication in the first place (i.e. ‘jwt_url’ is set).
wbolster-eiq added a commit that referenced this pull request Nov 16, 2020
As a follow-up to #76 and #77, only try to refresh a JWT token if using
JWT authentication in the first place (i.e. ‘jwt_url’ is set).
wbolster-eiq added a commit that referenced this pull request Nov 18, 2020
As a follow-up to #76 and #77, only try to refresh a JWT token if using
JWT authentication in the first place (i.e. ‘jwt_url’ is set).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants