Feat/3speak video upload #1353
Feat/3speak video upload #1353
Conversation
…into feat/3speak-video-upload
…into feat/3speak-video-upload
…into feat/3speak-video-upload
…ecency-vision into feat/3speak-video-upload
…ecency-vision into feat/3speak-video-upload
| @@ -256,11 +261,11 @@ export class EditorToolbar extends Component<Props> { | |||
| }; | |||
|
|
|||
| bold = () => { | |||
| this.insertText("**", "**"); | |||
| this.insertText("*", "*"); | |||
There was a problem hiding this comment.
Why this is modified? @Adesojisouljay
There was a problem hiding this comment.
Ah, I don't know how i=I broke this. fixed
| }; | ||
|
|
||
| italic = () => { | ||
| this.insertText("*", "*"); | ||
| this.insertText("", ""); |
| @@ -555,6 +562,20 @@ export class EditorToolbar extends Component<Props> { | |||
| </div> | |||
| </Tooltip> | |||
| )} | |||
|
|
|||
| {!this.props.comment && ( | |||
| <Tooltip content="Upload Video"> | |||
There was a problem hiding this comment.
Tooltip message should be translated
|
|
||
| if (years > 0) { | ||
| if (years === 1) { | ||
| return `${years} year ago`; |
There was a problem hiding this comment.
There is helper or function with this, why this is being handled manually? Check dateToRelative or parse-date.ts file.
| if (data) { | ||
| setVideoId(data._id); | ||
| setIsNsfwC(data.isNsfwContent); | ||
| success("Video succesfully uploaded"); |
| export const VideoUpload = (props: Props) => { | ||
| const { activeUser, global, insertText, setVideoEncoderBeneficiary, toggleNsfwC } = props; | ||
|
|
||
| const tusEndPoint = "https://uploads.3speak.tv/files/"; |
There was a problem hiding this comment.
@Adesojisouljay Would it be possible to move these endpoint and upload functions inside api/threespeak.ts file instead? Also please check that all helpers related to vide upload to be in that file, not in components. Otherwise we will struggle later to find which endpoint is down or needs updating.
There was a problem hiding this comment.
Okay, I'll check that also.
Thanks
|
🙏😊
…On Thu, 3 Aug 2023, 7:49 am Feruz M, ***@***.***> wrote:
***@***.**** approved this pull request.
lgtm, lets test 🚀
—
Reply to this email directly, view it on GitHub
<#1353 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVAB2UUVAYLHZPDOKHE3XITXTNCWPANCNFSM6AAAAAAYXLX46A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No description provided.