Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Ads #70

Closed
emiliou4756 opened this issue Apr 21, 2020 · 15 comments
Closed

Several Ads #70

emiliou4756 opened this issue Apr 21, 2020 · 15 comments

Comments

@emiliou4756
Copy link

Hello,
all details (screenshots with marked ads) here:

uBlockOrigin/uAssets#7270

monzta added a commit that referenced this issue Apr 21, 2020
@monzta
Copy link
Member

monzta commented Apr 21, 2020

a37e16c
easylist/easylist@03042e6
easylist/easylist@e146cf3
easylist/easylist@6999a4d

Ads on godmode-trader.de seem to appear due to @@||godmode-trader.de^$ghide in uBlock filters. This should either be removed if no longer needed or site-specific lement hiding filters should be added there.

@monzta monzta closed this as completed Apr 21, 2020
@monzta
Copy link
Member

monzta commented Apr 22, 2020

These are generic enough to be added to EasyList.

@emiliou4756
Copy link
Author

emiliou4756 commented Apr 22, 2020

@monzta
Copy link
Member

monzta commented Apr 22, 2020

@emiliou4756 thanks, I'll check this soonish.

@kulfoon I don't understand..how would I know that?

@monzta monzta reopened this Apr 22, 2020
@monzta
Copy link
Member

monzta commented Apr 23, 2020

If I think a filter is good enough to be generic, I add it to EasyList as it could potentially block/hide something on another page. I doubt publicwww.com crawled every website in the world. So you just don't know if it will work on another site right now or even in the future. I don't understand how /adspace_finative-$domain=www.ariva.de is "more logical and efficient" than /adspace_finative-. Can you elaborate? The site-specific one will only work on www.ariva.de. How is that more more logical and efficient if adding it without the $domain= option could potentially block the same or a similar request on another page? I don't see any advantage in using the site-specific one instead.

@monzta
Copy link
Member

monzta commented Apr 25, 2020

But most of them, and definately all most important ones.

https://publicwww.com/: 536 229 312 web pages indexed
https://www.internetlivestats.com/total-number-of-websites/: 1 766 000 000+ Websites online right now

Nor you, also having just 1 affected website among 1 billion websites indexed by publicwww it's unlikely to find another one, as it shows obvious thing that such a single website with a unique dom/network request's name is just a single alone random case in the ocean.

If there is a likelihood, it will usually end up in EasyList as a generic filter.

As seen, it's all about efficiency/performance/resources saving

In #70 (comment) you mention generic blocking rules while in uBO there is a warning for generic element hiding rules. Currently there are 8900 lines in easylist_general_block.txt and easylist_general_block_dimensions.txt. That's without generic adserver (16188+1080) and third-party (1854+454) filters (lines =| filters as there are also some comments). I'm not aware of any perfomance issues with such filters. I know that processing and applying filters in general has been improved considerably in the last years in mayor adblock extesion and products such as Cliqz, Adblock Plus, AdBlock and I think Brave too.

monzta added a commit that referenced this issue Apr 25, 2020
@monzta
Copy link
Member

monzta commented Apr 25, 2020

@emiliou4756

https://www.ariva.de/news/dramatische-oelpreis-auswirkungen-deshalb-muessen-infineon-8360384

Showing due to @@||ariva.de^$ghide in uBlock filters. It should be removed or add ariva.de##.werb_textlink to uBlock filters.

@monzta
Copy link
Member

monzta commented Apr 26, 2020

@emiliou4756 ping @mapx-

Where do you see ads on the other sites?

@kulfoon
Copy link

kulfoon commented Apr 26, 2020

uBlockOrigin/uBlock-issues#738 (comment)

Great, if it just was written in the tooltip I mentioned, that would be good, but it seems you are not of those who claim that their description may have been confusing/misleading and making you looking like denying your own tooltip, and making the one who was confused looking foolish, and locking a thread makes the one looking yet more foolish because he is unable to reply/defend. I didn't dig so deep into uBO, as I just sticked to what was suggested in the uBO's tooltip, thus I thought every added generic filter eats some cycles. But as seen, since now I won't trust at 100% to any tooltip anymore in any program. See: another similiar case

And locking threads and forcing people to answer elsewhere sucks, you did it not the first time, no further comment on such admins.

@mapx-
Copy link

mapx- commented Apr 26, 2020

@emiliou4756
fixed anti adb warning for uBO (just enable uBO annoyances list)
uBlockOrigin/uAssets@0510542

@mapx-
Copy link

mapx- commented Apr 26, 2020

@monzta

on spiegel.de (home page for example) , even disabling ghide filter there are some blank placeholders
image

@mapx-
Copy link

mapx- commented Apr 26, 2020

@monzta for the big placeholder see if helps:
spiegel.de##[data-component="HTMLEmbed"]

@emiliou4756
Copy link
Author

@mapx-
always in private surfmode - sometimes in normal mode...

Spiegel:
image

Zeit:
image

@mapx-
Copy link

mapx- commented Apr 27, 2020

@emiliou4756 It's not about ads or anti adblocking.

I tried for example spiegel.de##+js(aopr, document.cookie)
but it seems is breaking the comments and possibly other stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants