Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix writing spider cache for Lmod >= 8.7.12 #4402

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Dec 14, 2023

(created using eb --new-pr)

https://lmod.readthedocs.io/en/latest/125_personal_spider_cache.html

NOTE: Lmod versions earlier than 8.7.12 wrote the cache file to ~/.lmod.d/.cache


self.supports_depends_on = version >= self.REQ_VERSION_DEPENDS_ON
# See https://lmod.readthedocs.io/en/latest/125_personal_spider_cache.html
if version >= '8.7.12':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if version >= '8.7.12':
if version >= StrictVersion('8.7.12'):

Not sure if this is necessary or not, but at least it keeps consistency with how other versions are being treated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it is not necessary and in fact I changed the self.supports_depends_on to be consistent with this. I prefer this shorter variant when it is clear one operand is already a version instance (which is the case here as it is created right above)

@Flamefire Flamefire force-pushed the 20231214104020_new_pr_GrKzLLVElk branch from 07eacdd to b4488e0 Compare December 14, 2023 10:00
@boegel boegel added the bug fix label Dec 20, 2023
@boegel boegel added this to the next release (4.9.0?) milestone Dec 20, 2023
@boegel boegel changed the title Fix writing spider cache for LMod >= 8.7.12 fix writing spider cache for Lmod >= 8.7.12 Dec 20, 2023
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Member

fixes #4262 ?

@boegel
Copy link
Member

boegel commented Dec 20, 2023

fixes #4262 ?

Only partially, EasyBuild still only create a moduleT.lua file, which is silently ignored if there's also a spiderT.x86_64_Linux.lua (or *.luac), so more work is needed, but that can be done in a follow-up PR, the changes being made here are definitely a step in the right direction.

@Flamefire
Copy link
Contributor Author

Together with #4403 and the right configuration locally it should fix that issue

@boegel boegel merged commit a2eaf23 into easybuilders:develop Dec 22, 2023
39 checks passed
@Flamefire Flamefire deleted the 20231214104020_new_pr_GrKzLLVElk branch December 23, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants