-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix writing spider cache for Lmod >= 8.7.12 #4402
fix writing spider cache for Lmod >= 8.7.12 #4402
Conversation
|
||
self.supports_depends_on = version >= self.REQ_VERSION_DEPENDS_ON | ||
# See https://lmod.readthedocs.io/en/latest/125_personal_spider_cache.html | ||
if version >= '8.7.12': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if version >= '8.7.12': | |
if version >= StrictVersion('8.7.12'): |
Not sure if this is necessary or not, but at least it keeps consistency with how other versions are being treated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it is not necessary and in fact I changed the self.supports_depends_on
to be consistent with this. I prefer this shorter variant when it is clear one operand is already a version instance (which is the case here as it is created right above)
07eacdd
to
b4488e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fixes #4262 ? |
Only partially, EasyBuild still only create a |
Together with #4403 and the right configuration locally it should fix that issue |
(created using
eb --new-pr
)https://lmod.readthedocs.io/en/latest/125_personal_spider_cache.html