fix support for Environment Modules as modules tool to pass unit tests with v4.2+ #4369
Conversation
test_load expects that version 4.2+ of Environment Modules reload an already loaded module. As of version 5.3, already loaded modules are not reloaded unless one of their dependent module is unloaded or loaded.
Defines environment variables when initializing EnvironmentModules object to ensure that this module tool will not be influenced by external configuration. Setup Environment Modules configuration to ensure module search behaves like EasyBuild expects (match module name start, case sensitive, return in-depth modulepath content, ignore cache file). Also defines a basic output configuration not to get unexpected content like tags or variants. This change helps to pass "test_avail" test with Environment Modules v5.0+.
Starting Environment Modules 4.2, value of setenv statement in "module show" output is enclosed in curly braces if it contains spaces. This change helps to pass "test_get_setenv_value_from_modulefile" test with Environment Modules v4.2+
b71560d to
f297d32
Compare
There was a problem hiding this comment.
@xdelaruelle Let's also update .github/workflows/unit_tests.yml to test with a more recent version of Environment Modules, to verify that these changes are sufficient to pass the tests (and to help ensure that we don't accidentally break support for recent Environment Modules later)?
Just one or two extra "key" versions is enough, maybe we should also stop testing with the now ancient v4.1.4 (we shouldn't have too many test configurations).
@boegel This is what I have prepared in another PR that I will push as soon as #4369 and #4371 will get merged. These two PRs are needed for the CI to pass with Environment Modules v4.2+. EL8 is now shipping Environment Modules v4.5, so I will propose to change the v4.1.4 key by v4.5 |
On my way to work on #4368 I have found that some unit tests (test_avail, test_load and test_get_setenv_value_from_modulefile) are failing with Environment Modules v4.2+.
Here are some changes to either update: