Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using $HOME/.cargo in poetry build #22257

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Feb 4, 2025

(created using eb --new-pr)

Switch to CargoPythonBundle as Rust is used for rpds_py. This sets $CARGO_HOME so $HOME is not used for reading the cargo config which may lead to errors.

Requires

@github-actions github-actions bot added the change label Feb 4, 2025
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
n1154 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17
See https://gist.github.com/Flamefire/917f11cdab5b1c6728ebcc9bfc152fbf for a full test report.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3576
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
n1714 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17
See https://gist.github.com/Flamefire/da4da9879e15975fd7c7bd455ea145fa for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added the bug fix label Feb 5, 2025
@Micket Micket added this to the release after 4.9.4 milestone Feb 5, 2025
@Flamefire
Copy link
Contributor Author

@Micket you need the easyblock PR 3576 or this likely fails

@Micket
Copy link
Contributor

Micket commented Feb 10, 2025

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 3576"

@Micket
Copy link
Contributor

Micket commented Feb 12, 2025

Test report by @Micket
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3576
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/3e489227c8ade06b3651e49f536bc57d for a full test report.

@Micket
Copy link
Contributor

Micket commented Feb 12, 2025

Dunno why bot keeps ignoring me, but i don't have time to deal with that right now. This needs fixing and looks good, merging.

@Micket Micket merged commit a71a597 into easybuilders:develop Feb 12, 2025
10 checks passed
@Flamefire Flamefire deleted the 20250204153249_new_pr_poetry109 branch February 13, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants