{lib}[foss/2022a] PyTorch-Lightning v1.8.4 w/ Python 3.10.4

[surak]

(created using eb --new-pr)

[SebastianAchilles]

Test report by @SebastianAchilles
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
bwd-rockylinux-90 - Linux Rocky Linux 9.0 (Blue Onyx), x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.9.10
See https://gist.github.com/8bff5f56c6dfed92517818a027285eb6 for a full test report.

[SebastianAchilles]

The error I get is:

ModuleNotFoundError: No module named 'hatchling'

termcolor >=2.0.0 requires hatchling: https://github.com/termcolor/termcolor/blob/2.1.0/pyproject.toml#L5

This PR requires #16402

[SebastianAchilles]

Test report by @SebastianAchilles
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
bwd-rockylinux-91 - Linux Rocky Linux 9.1 (Blue Onyx), x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), 2 x NVIDIA NVIDIA GeForce GTX 1060 6GB, 515.86.01, Python 3.9.14
See https://gist.github.com/eb598f76714b94129aa88e2e7ec6a8fe for a full test report.

[SebastianAchilles]

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bwd-rockylinux-91 - Linux Rocky Linux 9.1 (Blue Onyx), x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), 2 x NVIDIA NVIDIA GeForce GTX 1060 6GB, 515.86.01, Python 3.9.14
See https://gist.github.com/4907ad747a729306d03defc617bc4428 for a full test report.

[lexming]

Sorry to be a bother, but I'm still not convinced that termcolor and fire are dependencies. After looking into the dependencies a bit more, I have the impression that we even have some missing ones, like lightning_api_access. We should probably follow the list of requirements in https://github.com/Lightning-AI/lightning/blob/1.8.2/requirements.txt

[surak]

Sorry to be a bother, but I'm still not convinced that termcolor and fire are dependencies. After looking into the dependencies a bit more, I have the impression that we even have some missing ones, like lightning_api_access. We should probably follow the list of requirements in https://github.com/Lightning-AI/lightning/blob/1.8.2/requirements.txt

Hey Alex, would you be so kind to make the edits incorporating these changes you propose? I will accept them right away!

[lexming]

@surak done in surak#4

I took the chance to also update to v1.8.4. All dependencies and extensions follow the requirements listed in https://github.com/Lightning-AI/lightning/blob/1.8.4/requirements.txt

[surak]

@surak done in surak#4

I took the chance to also update to v1.8.4. All dependencies and extensions follow the requirements listed in https://github.com/Lightning-AI/lightning/blob/1.8.4/requirements.txt

Thank you so much! You made a much better job than I did!

[lexming]

@boegelbot: please test @ generoso

[boegelbot]

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16681 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16681 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

• exit code: 0
• output:

Submitted batch job 9737

Test results coming soon (I hope)...

- notification for comment with ID 1345421521 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

[boegelbot]

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/5ef53551d8a8e225e727b14c4225eca4 for a full test report.

[lexming]

LGTM

@SebastianAchilles what do you think? is this ok on your side?

[SebastianAchilles]

Looks good to me as well.

Thanks a lot @lexming and @surak

[SebastianAchilles]

Going in, thanks @surak!