Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt module_load_environment: imkl #3555

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Jan 14, 2025

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added the change label Feb 9, 2025
@boegel
Copy link
Member

boegel commented Feb 9, 2025

Hmm, when I diff the generated module file, I see some differences, so seems like this needs a closer look.

For imkl/2020.4.304-iompi-2020b.lua:

 prepend_path("CPATH", pathJoin(root, "mkl/include"))
 prepend_path("CPATH", pathJoin(root, "mkl/include/fftw"))
 prepend_path("LD_LIBRARY_PATH", pathJoin(root, "mkl/lib/intel64"))
-prepend_path("LIBRARY_PATH", pathJoin(root, "mkl/lib/intel64"))
+prepend_path("LIBRARY_PATH", pathJoin(root, "lib64"))
 prepend_path("PKG_CONFIG_PATH", pathJoin(root, "mkl/bin/pkgconfig"))
 setenv("EBROOTIMKL", root)
 setenv("EBVERSIONIMKL", "2020.4.304")

For imkl/2024.2.0.lua:

 prepend_path("FLEXIBLAS_LIBRARY_PATH", pathJoin(root, "mkl/2024.2/lib/intel64/flexiblas"))
 prepend_path("LD_LIBRARY_PATH", pathJoin(root, "compiler/2024.2/lib"))
 prepend_path("LD_LIBRARY_PATH", pathJoin(root, "mkl/2024.2/lib/intel64"))
-prepend_path("LIBRARY_PATH", pathJoin(root, "compiler/2024.2/lib"))
-prepend_path("LIBRARY_PATH", pathJoin(root, "mkl/2024.2/lib/intel64"))
 prepend_path("PKG_CONFIG_PATH", pathJoin(root, "mkl/2024.2/lib/pkgconfig"))
 setenv("EBROOTIMKL", root)
 setenv("EBVERSIONIMKL", "2024.2.0")

@boegel
Copy link
Member

boegel commented Feb 10, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS imkl-2020.4.304-gompi-2020b.eb
  • SUCCESS imkl-2020.4.304-gompic-2020b.eb
  • SUCCESS imkl-2020.4.304-iimpi-2020b.eb
  • SUCCESS imkl-2020.4.304-iimpic-2020b.eb
  • SUCCESS imkl-2020.4.304-iompi-2020b.eb
  • SUCCESS imkl-2021.1.1-iimpi-2020.12.eb
  • SUCCESS imkl-2021.2.0-gompi-2021a.eb
  • SUCCESS imkl-2021.2.0-iimpi-2021a.eb
  • SUCCESS imkl-2021.2.0-iompi-2021a.eb
  • SUCCESS imkl-2021.3.0-gompi-2021a.eb
  • SUCCESS imkl-2021.4.0-iompi-2021b.eb
  • SUCCESS imkl-2021.4.0.eb
  • SUCCESS imkl-2022.0.1.eb
  • SUCCESS imkl-2022.1.0-gompi-2022a.eb
  • SUCCESS imkl-2022.1.0.eb
  • SUCCESS imkl-2022.2.0.eb
  • SUCCESS imkl-2022.2.1.eb
  • SUCCESS imkl-2023.0.0.eb
  • SUCCESS imkl-2023.1.0-gompi-2023a.eb
  • SUCCESS imkl-2023.1.0.eb
  • SUCCESS imkl-2023.2.0-gompi-2023b.eb
  • SUCCESS imkl-2023.2.0.eb
  • SUCCESS imkl-2024.0.0.eb
  • SUCCESS imkl-2024.2.0.eb

Build succeeded for 24 out of 24 (24 easyconfigs in total)
node3581.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/7b69c43a35c95677f405e137017e4c07 for a full test report.

@boegel boegel merged commit 6073ac5 into easybuilders:5.0.x Feb 10, 2025
19 checks passed
@lexming lexming deleted the modload-imkl branch February 10, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Breaking changes
Development

Successfully merging this pull request may close these issues.

2 participants