Update with master #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the pathological backtracking in the regexp so that we
don't need the RE2 gem anymore.
The problem was the `(\w+\s*){1,3}` part. Since we accept 0 or more
spaces, and 1 to 3 times, the regex engine would keep backtracking to
figure out if it should do 1, 2, or 3 matches. We know we want at
least one match, and it *must* be followed by one or more spaces. If we
remove the space before the "y", we can eliminate the backtracking by
making at least one space required (as the original regular expression
indicated)
Fix pathological backtracking in signature regexp
Signed-off-by: Zack Koppert <zkoppert@github.com>
Add timeout to prevent infinite run
Signed-off-by: Zack Koppert <zkoppert@github.com>
Update tests to address code scanning issues
…-2c46846ebab6 Enable Dependabot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.