24772-Update API Specs and Unit Test Mocks (bcgov#3178)

* 24772-Update specs and mocks in unit test * 24772-Add-new-properties-to-success-response * 24772-Update titles to reflect changes in schema
eason-pan-bc · Jan 23, 2025 · 026d984 · 026d984
1 parent 149d3c9
commit 026d984
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/docs/business.yaml b/docs/business.yaml
@@ -726,6 +726,8 @@ paths:
                         submitter: 'mocked submitter'
                       noticeOfWithdrawal:
                         filingId: 123456
+                        hasTakenEffect: false
+                        partOfPoa: false
                 voluntary-dissolution-success-response:
                   summary: Voluntary Dissolution Response
                   value:
@@ -1523,6 +1525,8 @@ paths:
                       courtOrder:
                         fileNumber: "A12345"
                         effectOfOrder: planOfArrangement
+                      hasTakenEffect: false
+                      partOfPoa: false
               voluntary-dissolution-request:
                 summary: Voluntary Dissolution Request
                 value:
@@ -6355,6 +6359,12 @@ components:
               title: ID for the future effective filing
             courtOrder:
               $ref: '#/components/schemas/Court_order'
+            hasTakenEffect:
+              type: boolean
+              title: One of the terms of arrangement for the FED filing have taken effect
+            partOfPoa:
+              type: boolean
+              title: FED filing is part of a Plan of Arrangement
       x-examples:
         Example 1:
           noticeOfWithdrawal:

diff --git a/legal-api/tests/unit/resources/v2/test_business_filings/test_filing_documents.py b/legal-api/tests/unit/resources/v2/test_business_filings/test_filing_documents.py
@@ -141,12 +141,11 @@ def test_unpaid_filing(session, client, jwt):
 ALTERATION_MEMORANDUM_RULES_IN_RESOLUTION['memorandumInResolution'] = True
 ALTERATION_MEMORANDUM_RULES_IN_RESOLUTION['rulesInResolution'] = True
 
-# a mock notice of withdrawal filing, since its schema is not ready yet
-# may need to delete this and change variables in the test cases in the future
 MOCK_NOTICE_OF_WITHDRAWAL = {}
 MOCK_NOTICE_OF_WITHDRAWAL['courtOrder'] = copy.deepcopy(COURT_ORDER)
 MOCK_NOTICE_OF_WITHDRAWAL['filingId'] = '123456'
-
+MOCK_NOTICE_OF_WITHDRAWAL['hasTakenEffect'] = False
+MOCK_NOTICE_OF_WITHDRAWAL['partOfPoa'] = False
 
 @pytest.mark.parametrize('test_name, identifier, entity_type, filing_name_1, legal_filing_1, filing_name_2, legal_filing_2, status, expected_msg, expected_http_code, payment_completion_date', [
     ('special_res_paper', 'CP7654321', Business.LegalTypes.COOP.value,