Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only retrieve a version that has at least 6 assets #90

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

idodod
Copy link
Contributor

@idodod idodod commented Apr 18, 2024

Address #23

@idodod idodod marked this pull request as ready for review April 18, 2024 05:13
@idodod idodod requested a review from a team as a code owner April 18, 2024 05:13
Copy link
Contributor

@alexcb alexcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is much nicer than implementing a retry loop; very nice solution!

@idodod idodod merged commit b6ad1e7 into main Apr 18, 2024
14 checks passed
@idodod idodod deleted the ido-get-version-with-assets branch April 18, 2024 17:38
robarnold referenced this pull request in marinatedconcrete/config May 2, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [earthly/actions-setup](https://togithub.com/earthly/actions-setup) |
action | patch | `v1.0.12` -> `v1.0.13` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>earthly/actions-setup (earthly/actions-setup)</summary>

###
[`v1.0.13`](https://togithub.com/earthly/actions-setup/releases/tag/v1.0.13)

[Compare
Source](https://togithub.com/earthly/actions-setup/compare/v1.0.12...v1.0.13)

#### What's Changed

- Update dependency
[@&#8203;types/node](https://togithub.com/types/node) to v20.12.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/earthly/actions-setup/pull/81](https://togithub.com/earthly/actions-setup/pull/81)
- Update npm (non-major) to v7.5.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/earthly/actions-setup/pull/82](https://togithub.com/earthly/actions-setup/pull/82)
- Update dependency
[@&#8203;octokit/plugin-paginate-rest](https://togithub.com/octokit/plugin-paginate-rest)
to v11 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/earthly/actions-setup/pull/84](https://togithub.com/earthly/actions-setup/pull/84)
- Update npm (non-major) by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/earthly/actions-setup/pull/83](https://togithub.com/earthly/actions-setup/pull/83)
- Update npm (non-major) to v7.6.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/earthly/actions-setup/pull/86](https://togithub.com/earthly/actions-setup/pull/86)
- Update npm (non-major) by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/earthly/actions-setup/pull/87](https://togithub.com/earthly/actions-setup/pull/87)
- Update npm (non-major) to v7.7.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/earthly/actions-setup/pull/88](https://togithub.com/earthly/actions-setup/pull/88)
- only retrieve a version that has at least 6 assets by
[@&#8203;idodod](https://togithub.com/idodod) in
[https://github.com/earthly/actions-setup/pull/90](https://togithub.com/earthly/actions-setup/pull/90)
[https://github.com/earthly/actions-setup/issues/23](https://togithub.com/earthly/actions-setup/issues/23)
- Update dependency
[@&#8203;octokit/plugin-paginate-rest](https://togithub.com/octokit/plugin-paginate-rest)
to v11.1.1 by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/earthly/actions-setup/pull/91](https://togithub.com/earthly/actions-setup/pull/91)

**Full Changelog**:
earthly/actions-setup@v1.0.12...v1.0.13

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/marinatedconcrete/config).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants