feat: unify API on snapshot_id #770
Merged
+52
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
509532c to
30edf17
Compare
|
I am pretty sure changing the RefData would have broken format stability (maybe not, I'm not sure), so good call reverting that. I think you got all the important points, the user facing API def the most important here |
|
CI failing due to newly unmaintained ring dependency. |
|
Ya saw that yesterday... once I fix that later, I'll get this merged in. Thanks a lot! |
mpiannucci
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning the parameter names: always using
snapshot_idfor the string idCloses #676
Made the changes in
ancestryasync_ancestrydiffreadonly_sessionThere are a few more errors that could be changed (1, 2) and some internal uses (example) that I didn't change. Let me know if they should also be aligned.