Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getsize benchmark #742

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Fix getsize benchmark #742

merged 2 commits into from
Feb 18, 2025

Conversation

dcherian
Copy link
Contributor

Zarr doesn't support a preceding slash either, so I think icechunk was mistakenly supporting it.

import zarr
store = zarr.storage.MemoryStore()

group = zarr.group(store)

array = group.create_array("array", shape=(1,2,3), dtype="float32")

print(await store.getsize("array/zarr.json")) # works
await store.getsize("/array/zarr.json") #error

@dcherian dcherian enabled auto-merge (squash) February 18, 2025 04:42
@dcherian dcherian merged commit fb3f768 into main Feb 18, 2025
5 checks passed
@dcherian dcherian deleted the fix-getsize branch February 18, 2025 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants