Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse already defined max instead of std numerx #482

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

mahf708
Copy link
Contributor

@mahf708 mahf708 commented Jul 21, 2024

A pretty minor fix to suppress an annoying warning :)

min, max, etc were already defined in haero maths, so reusing them here instead of std (to special-case cuda...)

@mahf708
Copy link
Contributor Author

mahf708 commented Jul 21, 2024

cc @singhbalwinder @jeff-cohere

the warning was of the form:

.../scream/externals/haero/haero/root_finders.hpp(49): warning #20013-D: calling a constexpr __host__ function("max") from a __host__ __device__ function("NewtonSolver") is not allowed. The experimental flag '--expt-relaxed-constexpr' can be used to allow this.
          iter_diff(std::numeric_limits<Real>::max()), f(fn), fail(false) {}

@singhbalwinder
Copy link
Collaborator

Thanks, Naser!

@singhbalwinder singhbalwinder merged commit 0dff12a into eagles-project:main Jul 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants