Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable shared libs build #481

Merged
merged 1 commit into from
Jun 10, 2024
Merged

enable shared libs build #481

merged 1 commit into from
Jun 10, 2024

Conversation

mahf708
Copy link
Contributor

@mahf708 mahf708 commented May 31, 2024

xref eagles-project/mam4xx#323

We would like to be able to build the entire eamxx project with shared libs enabled, so making the change here.

There may be other changes needed elsewhere, but for now, I believe this is all that is needed.

Putting this PR together so that you can see how this affects your CI and so on.

Tagging @jeff-cohere @singhbalwinder @odiazib @bartgol

@bartgol
Copy link

bartgol commented Jun 10, 2024

Can we merge this?

@jeff-cohere jeff-cohere merged commit 8e4c96d into eagles-project:main Jun 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-cohere jeff-cohere jeff-cohere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahf708 @bartgol @jeff-cohere