Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add FPEs to mam4xx unit testing #479

Merged
merged 3 commits into from
Mar 18, 2024
Merged

add FPEs to mam4xx unit testing #479

merged 3 commits into from
Mar 18, 2024

Conversation

mjs271
Copy link

@mjs271 mjs271 commented Mar 18, 2024

This modifies testing.{c,h}pp to enable FPEs, via EKAT, for mam4xx unit tests.

odiazib
odiazib approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@odiazib odiazib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@mjs271 mjs271 mentioned this pull request Mar 18, 2024
Merged
jeff-cohere
jeff-cohere approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@jeff-cohere jeff-cohere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that you seem to have uncovered something weird in the math unit test! This looks good to me too, and I'm approving pending a fix for the failing test. Thanks for shaking out this part of the code, Mike!

Michael J. Schmidt and others added 2 commits March 18, 2024 12:29
@mjs271 mjs271 merged commit 720bd29 into main Mar 18, 2024
5 checks passed
@mjs271 mjs271 deleted the mjs/FPEs_4unitTests branch March 18, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-cohere jeff-cohere jeff-cohere approved these changes

@odiazib odiazib odiazib approved these changes

@overfelt overfelt Awaiting requested review from overfelt

@singhbalwinder singhbalwinder Awaiting requested review from singhbalwinder

@jaelynlitz jaelynlitz Awaiting requested review from jaelynlitz

Assignees
No one assigned
Labels
bug fix testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjs271 @jeff-cohere @odiazib @mjschmidt271