Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorter python client imports, fix windows docker client #37

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

BSchilperoort
Copy link
Member

@BSchilperoort BSchilperoort commented Nov 20, 2024

Fixes #31 partially

Encountered issue on windows: os.getuid() is not available. Fixed this by getting the windows username.

@BSchilperoort BSchilperoort changed the title Shorter python client imports Shorter python client imports, fix windows docker client Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.80%. Comparing base (f8d247f) to head (8bedcb4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   55.41%   49.80%   -5.62%     
==========================================
  Files           6        9       +3     
  Lines         406      518     +112     
  Branches        8       27      +19     
==========================================
+ Hits          225      258      +33     
- Misses        179      257      +78     
- Partials        2        3       +1     
Components Coverage Δ
Python 49.80% <81.81%> (-5.62%) ⬇️
Julia ∅ <ø> (∅)
R ∅ <ø> (∅)
---- 🚨 Try these New Features:

@BSchilperoort
Copy link
Member Author

Coverage seems lower but isn't (only linux coverage is uploaded)

@BSchilperoort BSchilperoort merged commit 6c79062 into main Nov 20, 2024
14 of 17 checks passed
@BSchilperoort BSchilperoort deleted the shorter-python-client branch November 20, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shorter python import
1 participant