-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22191] Add tutorial on how to avoid fully-connected network in ROS 2 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciaEchevarria99
changed the title
Add tutorial on how to avoid fully-connected network in ROS 2
[22191] Add tutorial on how to avoid fully-connected network in ROS 2
Nov 18, 2024
Javgilavi
requested changes
Nov 19, 2024
docs/rst/tutorials/core/wifi/router_fully_connected/router_fully_connected.rst
Outdated
Show resolved
Hide resolved
docs/rst/tutorials/core/wifi/router_fully_connected/router_fully_connected.rst
Outdated
Show resolved
Hide resolved
docs/rst/tutorials/core/wifi/router_fully_connected/router_fully_connected.rst
Outdated
Show resolved
Hide resolved
docs/rst/tutorials/core/wifi/router_fully_connected/router_fully_connected.rst
Show resolved
Hide resolved
Javgilavi
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
…n introductory section Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
LuciaEchevarria99
force-pushed
the
tutorial/fully-connected
branch
from
November 28, 2024 09:31
076d309
to
9d862ce
Compare
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
* Add tutorial on how to avoid fully-connected network in ROS 2 Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Change tutorial to Wifi & Large data tutorials, delete tabs and add an introductory section Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Apply suggested changes Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Add missing blank space in yaml file Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Fix spelling Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Fix end of file Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> --------- Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> (cherry picked from commit 108f0bd) # Conflicts: # docs/rst/tutorials/core/wifi/wifi_tutorials.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.