Fixed test dependency #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightlies have failed to build twice in a row. An example can be found here
A 404 error is shown while trying to get
raw.githubusercontent.com/catchorg/Catch2/master/single_include/catch2/catch.hpp. Seems like the master branch has been removed onCatch2, which is the framework used for testing.This commit on the upstream repository fixed the dependency, but we are fixed to a previous commit here, so with this PR we cherry pick the solution when we want to execute the upstream tests on the commit we are fixed to.
Signed-off-by: Miguel Company MiguelCompany@eprosima.com