Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options instead of forcing them #32

Merged

Conversation

mauropasse
Copy link
Contributor

When cross-compiling for RPi2, I got this error:

HEAD is now at c619113 Whitespace clean up (#70)
Submodule 'cmake/comp' (https://github.com/foonathan/compatibility.git) registered for path 'cmake/comp'
Cloning into '/root/ws/build/foonathan_memory_vendor/foo_mem-ext-prefix/src/foo_mem-ext/cmake/comp'...
/bin/sh: 1: ../tool/nodesize_dbg: not found
make[5]: *** [src/container_node_sizes_impl.hpp] Error 127
make[4]: *** [src/CMakeFiles/foonathan_memory.dir/all] Error 2
make[3]: *** [all] Error 2
make[2]: *** [foo_mem-ext-prefix/src/foo_mem-ext-stamp/foo_mem-ext-build] Error 2
make[1]: *** [CMakeFiles/foo_mem-ext.dir/all] Error 2
make: *** [all] Error 2
---
Failed   <<< foonathan_memory_vendor	[ Exited with code 2 ]

which lead me to add the option to not build the memory tools.

Signed-off-by: Mauro mpasserino@irobot.com

Signed-off-by: Mauro <mpasserino@irobot.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the mauro/add-build-tools-option branch from 9bba8bc to c98414a Compare September 23, 2020 06:57
@MiguelCompany MiguelCompany changed the title Add build memory tools option Add options instead of forcing them Sep 23, 2020
@MiguelCompany
Copy link
Member

@mauropasse Thanks for this. I extended it for the other two options, so we can let the user of the vendor package what values to use for all the options.

CMakeLists.txt Show resolved Hide resolved
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Copy link

@imontesino imontesino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit fa2cb36 into eProsima:master Sep 23, 2020
@mauropasse
Copy link
Contributor Author

Thanks @MiguelCompany !

@MiguelCompany MiguelCompany mentioned this pull request Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants