Support for Key topics

[manuelValch]

Hello,

Would like to know if keyed topics will be supported by this plotjuggler plugin ?

By that i mean in plotjuggler if the topic is keyed:
-declared in the data_type.xml, don't know if dynamic types carry this information

• Create a new time series in plotjuggler with topic_name + key
• Update this time series when receiving datas.

For example this Idl:

struct message1{
    @key string helloAppName
    @key unsigned long id
    unsigned long index;
    string message;
};

With a xml like this (this would require an update in the parser right ?):

<types>
    <type>
        <struct name="message1">
            <member name="AppName" type="string" isKey="true"/>
            <member name="id" type="uint32" isKey="true"/>
            <member name="index" type="uint32"/>
            <member name="message" type="string"/>
        </struct>
    </type>
</types>

Would create 1 time series per topic instance (my guess is that would be around FastDdsDataStreamer::on_topic_discovery methods).

Would be something like this:

Maybe it is already implemented and I missed it ?

[manuelValch]

Just taking notes with where I am currently (implementation not started at all)

• In dynamic type field key is already defined:

       <type>
            <struct name="my_keyed_struct">
                <member name="first" type="int32"/>
                <member name="second" type="int64"/>
                <member name="third" type="int32" key="true"/>
            </struct>
        </type>

• FastDdsDataStreamer::start() manages timeSeries creation (might have to move this part to another method public)
• ReaderHandler manages data reception, so it make sense (to me ...) to manage key value and instance state over there
• To split difference instances from a single topic I think I have to use PJ::PlotGroup
  -> putting this link here to remember it: https://github.com/PlotJuggler/plotjuggler-sample-plugins/blob/main/DataStreamSample/datastream_sample.cpp

Once a plotgroup is created for a keyed topic then I can dispatch (or create) the time series + its state

[EduPonz]

Hi @manuelValch,

Last week we merged eProsima/Fast-DDS#4694, which fixes support for keyed topics when types are defined through the XML API. This means that you can know use XML defined types to achieve what you want.

[manuelValch]

Hello,

yes saw that PR will keep going :)

[manuelValch]

Hi @manuelValch,

Last week we merged eProsima/Fast-DDS#4694, which fixes support for keyed topics when types are defined through the XML API. This means that you can know use XML defined types to achieve what you want.

Hello @EduPonz, just rebased on latest plugin version, could not find anymore the API key_annotation() has it been replaced with something else, Is there any doc where I could where it went ?