Minor change in configuration_request and test

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
eProsima · Jan 22, 2025 · 981b6c0 · 981b6c0
1 parent 45d2d28
commit 981b6c0
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 12 deletions.
diff --git a/sustainml_cpp/include/sustainml_cpp/orchestrator/OrchestratorNode.hpp b/sustainml_cpp/include/sustainml_cpp/orchestrator/OrchestratorNode.hpp
@@ -179,9 +179,8 @@ class OrchestratorNode
      * @param [in] req configuration request, contain which node and configuration file
      * @param [out] res response from the node with its new configuration
      */
-    bool configuration_request(
-            const types::RequestType req,
-            const types::ResponseType& res);
+    types::ResponseType configuration_request(
+            const types::RequestType& req);
 
     /**
      * @brief Public method to get the mutex in order to correctly synchronise user

diff --git a/sustainml_cpp/include/sustainml_cpp/types/types.hpp b/sustainml_cpp/include/sustainml_cpp/types/types.hpp
@@ -2519,7 +2519,7 @@ class RequestType
      * @brief This function returns the implementation
      * @return Pointer to implementation
      */
-    RequestTypeImpl* get_impl();
+    RequestTypeImpl* get_impl() const;
 
     /*!
      * @brief This function retrives the implementation type info
@@ -2706,7 +2706,7 @@ class ResponseType
      * @brief This function returns the implementation
      * @return Pointer to implementation
      */
-    ResponseTypeImpl* get_impl();
+    ResponseTypeImpl* get_impl() const;
 
     /*!
      * @brief This function retrives the implementation type info

diff --git a/sustainml_cpp/src/cpp/orchestrator/OrchestratorNode.cpp b/sustainml_cpp/src/cpp/orchestrator/OrchestratorNode.cpp
@@ -481,9 +481,8 @@ void OrchestratorNode::send_control_command(
     control_writer_->write(cmd.get_impl());
 }
 
-bool OrchestratorNode::configuration_request(
-        const types::RequestType req,
-        const types::ResponseType& res)
+types::ResponseType OrchestratorNode::configuration_request(
+        const types::RequestType& req)
 {
     //TODO: Implement this method
     return true;

diff --git a/sustainml_cpp/src/cpp/types/types.cpp b/sustainml_cpp/src/cpp/types/types.cpp
@@ -2234,7 +2234,7 @@ std::string& RequestType::configuration()
     return impl_->configuration();
 }
 
-RequestTypeImpl* RequestType::get_impl()
+RequestTypeImpl* RequestType::get_impl() const
 {
     return impl_;
 }
@@ -2398,7 +2398,7 @@ std::string& ResponseType::configuration()
     return impl_->configuration();
 }
 
-ResponseTypeImpl* ResponseType::get_impl()
+ResponseTypeImpl* ResponseType::get_impl() const
 {
     return impl_;
 }

diff --git a/sustainml_cpp/test/blackbox/common/BlackboxTestsOrchestratorNode.cpp b/sustainml_cpp/test/blackbox/common/BlackboxTestsOrchestratorNode.cpp
@@ -103,9 +103,9 @@ TEST(OrchestratorNode, OrchestratorConfigurationService)
     req.node_id(static_cast<long>(NodeID::ID_ML_MODEL_METADATA));
     req.transaction_id(1);
     req.configuration("Test");
-    types::ResponseType res;
+    types::ResponseType res = orchestrator.configuration_request(req);
 
-    ASSERT_TRUE(orchestrator.configuration_request(req, res));
+    ASSERT_TRUE(res.success());
     orchestrator.destroy();
 }