Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21685] Use different typename for TK_UINT8 and TK_BYTE #160

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Sep 17, 2024

Description

Currently IDL-Parser returns the typename uint8_t for TK_UINT8 and TK_BYTE. This provokes Fast-DDS-Gen generates the same typename for collections of this primitive types. This PR fixes it.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented.
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Use different typename for TK_UINT8 and TK_BYTE [21685] Use different typename for TK_UINT8 and TK_BYTE Sep 17, 2024
@MiguelCompany MiguelCompany added this to the v4.0.2 milestone Sep 17, 2024
@richiware richiware merged commit e49c39d into master Sep 20, 2024
2 checks passed
@richiware richiware deleted the bugfix/20878 branch September 20, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants