Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed submessage_size calculation on last data_frag <1.9.x>[7535] #999

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

MiguelCompany
Copy link
Member

Wireshark complains when the length of a fragment is not multiple of 4 bytes. This usually happens on the last fragment, as the fragment size is usually multiple of 4.

@MiguelCompany MiguelCompany changed the title Fixed submessage_size calculation on last data_frag <1.9.x> Fixed submessage_size calculation on last data_frag <1.9.x>[7535] Feb 4, 2020
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany added this to the v1.9.5 milestone Feb 5, 2020
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany force-pushed the bugfix/fragment-data-size/1.9.x branch from 4c6d40a to 54e0cdd Compare February 12, 2020 07:12
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany
Copy link
Member Author

Reuilding after changes on base branch

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany merged commit 5bc0e7b into 1.9.x Feb 13, 2020
@MiguelCompany MiguelCompany deleted the bugfix/fragment-data-size/1.9.x branch February 13, 2020 13:05
IkerLuengo added a commit that referenced this pull request Mar 2, 2020
MiguelCompany pushed a commit that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants