Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unwanted recoveries on liveliness tests <1.9.x> [7468] #983

Merged

Conversation

MiguelCompany
Copy link
Member

When the reader has automatic liveliness, but the writer does not, a PDP announcement from the writer can make the reader assert the liveliness of the writer, which is not expected by some tests. This PR tries to avoid this situation by increasing the PDP announcement period of the writer on those tests.

@richiware
Copy link
Member

richiware commented Jan 29, 2020

Build status:

  • Linux Build Status (unrelated failure)
  • Mac Build Status
  • Windows Build Status

Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM :D

@MiguelCompany MiguelCompany merged commit 11810da into 1.9.x Jan 29, 2020
@MiguelCompany MiguelCompany deleted the hotfix/improve-manual-automatic-liveliness-tests/1.9.x branch January 29, 2020 14:22
IkerLuengo added a commit that referenced this pull request Feb 21, 2020
This is a port of #982 + #983 + #985 from 1.9.x
IkerLuengo added a commit that referenced this pull request Feb 25, 2020
This is a port of #982 + #983 + #985 from 1.9.x
MiguelCompany pushed a commit that referenced this pull request Feb 25, 2020
This is a port of #982 + #983 + #985 from 1.9.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants