[7138] Bugfix/discovery server localhost #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
approved these changes
Jan 23, 2020
EduPonz
previously approved these changes
Jan 23, 2020
|
Build status:
|
MiguelCompany
requested changes
Jan 23, 2020
| * if possible | ||
| * @param nf NetworkFactory used to make the translation | ||
| */ | ||
| void transform_server_remote_locators(NetworkFactory & nf); |
There was a problem hiding this comment.
Suggested change
| void transform_server_remote_locators(NetworkFactory & nf); | |
| void transform_server_remote_locators( | |
| const NetworkFactory & nf); |
| @@ -143,6 +145,21 @@ bool BuiltinProtocols::updateMetatrafficLocators(LocatorList_t& loclist) | |||
| return true; | |||
| } | |||
|
|
|||
| void BuiltinProtocols::transform_server_remote_locators(NetworkFactory & nf) | |||
There was a problem hiding this comment.
Suggested change
| void BuiltinProtocols::transform_server_remote_locators(NetworkFactory & nf) | |
| void BuiltinProtocols::transform_server_remote_locators( | |
| const NetworkFactory & nf) |
|
Build status:
|
MiguelCompany
requested changes
Jan 23, 2020
|
Build status:
|
|
Build status:
|
|
Build status:
|
MiguelCompany
previously approved these changes
Jan 29, 2020
|
Build status:
|
Co-Authored-By: Miguel Company <miguelcompany@eprosima.com>
Co-Authored-By: Miguel Company <miguelcompany@eprosima.com>
Co-Authored-By: Miguel Company <miguelcompany@eprosima.com>
3ad9b8a to
5d1d200
Compare
|
Build status:
|
|
Build status:
|
MiguelCompany
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the same treatment given to the locators received via DATA, to the locators pass into the RemoteServerAttributes.
Basically the locators become localhost if possible to speed things up.