Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timed events unit tests [7379] #970

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Conversation

IkerLuengo
Copy link
Contributor

No description provided.

Make the test environment DELETE the service on TearDown.
Otherwise running the test multiple times with gtest_repeat
will cause a core.
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IkerLuengo IkerLuengo changed the title timed events unit tests [7377] timed events unit tests [7379] Jan 22, 2020
@richiware
Copy link
Member

richiware commented Jan 22, 2020

Build status:

  • Linux Build Status <-- (unrelated failure)
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany merged commit 626e6d5 into 1.9.x Jan 22, 2020
@MiguelCompany MiguelCompany deleted the bugfix/timed-events/1.9.x branch January 22, 2020 13:13
IkerLuengo added a commit that referenced this pull request Jan 22, 2020
IkerLuengo added a commit that referenced this pull request Feb 4, 2020
IkerLuengo added a commit that referenced this pull request Feb 13, 2020
MiguelCompany pushed a commit that referenced this pull request Feb 27, 2020
MiguelCompany added a commit that referenced this pull request Feb 28, 2020
* Refs #7007. Uncrustify.

* Refs #7007. Forward port of #879

* Refs #7007. Forward port of #942.

* Refs #7007. Forward port of #970

* Refs #7007. correct wrong rebase

* Refs 7007 Correct warning in windows

* Refs 7007 Forward port of #946

* Applu review suggestions

* Documentation on TimedEventImpl.h improved

* TimedEventImpl: Changing unique_lock to lock_guard

* Fixed ResourceEvent.cpp

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants