Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of STRICT_REALTIME <1.9.x>[7368] #967

Merged
merged 2 commits into from
Jan 29, 2020

Conversation

MiguelCompany
Copy link
Member

Not passing max_blocking_time to add_change_ unless strict realtime is enabled.

This was detected due to failures under valgrind on the blackbox test PubSubKeepAll, that sets max_blocking_time to 0

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany
Copy link
Member Author

MiguelCompany commented Jan 29, 2020

Failures should have been solved by #982, relaunching windows:

  • Windows Build Status (unrelated failure)

@MiguelCompany MiguelCompany merged commit 505ca4a into 1.9.x Jan 29, 2020
@MiguelCompany MiguelCompany deleted the hotfix/strict-realtime/1.9.x branch January 29, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants